Fix faraday use / adapter error #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
requested changes
May 2, 2020
|
Please fix the build, see Travis CI output for details. Add a paragraph to UPGRADING, bump major version. |
dblock
requested changes
May 4, 2020
UPGRADING.md
Outdated
|
|
||
| #### Faraday dependency changed to 1.0 | ||
|
|
||
| See [#75](https://github.com/ashkan18/graphlient/pull/75) |
dblock
requested changes
May 4, 2020
|
Heya @dblock , all addressed. |
dblock
requested changes
May 4, 2020
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References this issue: #73
Faraday has changed so we need to assign an adapter using
f.adapterrather thanf.use.As part of this PR, a few tests broke with nested errors etc. I've fixed them / got them all green, however I'm not too familiar with inner exceptions so it's worth a look from someone who knows a bit more than me :)
Will do changelog etc. shortly.
edit
ugh, I'm using Ruby 2.6, and this is 2.3. Having trouble getting Bundler to work with 2.3 :\